Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VF# Language Service, syntax coloring glitch due to empty hash directive #6400

Closed
smoothdeveloper opened this issue Mar 30, 2019 · 2 comments
Closed

VF# Language Service, syntax coloring glitch due to empty hash directive #6400

smoothdeveloper opened this issue Mar 30, 2019 · 2 comments
Labels
Area-LangService-API Bug
Milestone
16.3

Comments

@smoothdeveloper
Copy link
Contributor

In ilpars.fs, usage of empty directives such as # 3 "..\..\absil\ilpars.fsy" messes the colorization:

empty directive messing syntax coloring

Are those directives equivalent to #line?

It is worth enhancing the colorization code for it to complete on this file.
@cartermp cartermp added this to the 16.1 milestone Apr 1, 2019
@cartermp cartermp modified the milestones: 16.1, 16.2 Apr 23, 2019
@cartermp cartermp modified the milestones: 16.2, Backlog Apr 30, 2019
smoothdeveloper added a commit to smoothdeveloper/FsLexYacc that referenced this issue May 9, 2019
@smoothdeveloper
attempt to adjust printing of #line directives.
7fb41bb 
The way it was done breaks syntax coloring in VS:

# 123 "file.name" // broken

vs

#line 123 "file.name" // fixed

see dotnet/fsharp#6400
smoothdeveloper added a commit to smoothdeveloper/FsLexYacc that referenced this issue May 12, 2019
@smoothdeveloper
add --skip-line-directives optional flag to fslex and fsyacc.
e9554f7 
This is to work around colourization issue in VS in fsharp solution (dotnet/fsharp#6400)
@smoothdeveloper smoothdeveloper mentioned this issue May 12, 2019
Closed
@smoothdeveloper smoothdeveloper mentioned this issue Jun 14, 2019
Closed
@TIHan
Copy link
Contributor

TIHan commented Jun 19, 2019 •
edited
Loading

This is actually the same problem from issue #7000 . Closing as it's resolved.

@TIHan TIHan closed this as completed Jun 19, 2019
@cartermp cartermp modified the milestones: Backlog, 16.2 Jun 19, 2019
@realvictorprm
Copy link
Contributor

Finally!

@cartermp cartermp modified the milestones: Backlog, 15.3, 16.3 Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-API Bug
Projects
None yet
Milestone
16.3
Development

No branches or pull requests
4 participants
@smoothdeveloper @TIHan @cartermp @realvictorprm