VS enable diagnostics for unopened files (#15591)

* internalerror with MakeValueAssign fixed? * Add in optional setting for solution-wide background analysis * fix * telementry - lang service started will report background analysis flag
dotnet · Jul 17, 2023 · 40d789c · 40d789c
1 parent b4c26d8
commit 40d789c
Show file tree

Hide file tree

Showing 18 changed files with 176 additions and 17 deletions.
diff --git a/vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs b/vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
@@ -146,6 +146,9 @@ type internal FSharpWorkspaceServiceFactory [<Composition.ImportingConstructor>]
                             let captureIdentifiersWhenParsing =
                                 editorOptions.LanguageServicePerformance.CaptureIdentifiersWhenParsing
 
+                            // Default is false here
+                            let solutionCrawler = editorOptions.Advanced.SolutionBackgroundAnalysis
+
                             use _eventDuration =
                                 TelemetryReporter.ReportSingleEventWithDuration(
                                     TelemetryEvents.LanguageServiceStarted,
@@ -163,6 +166,7 @@ type internal FSharpWorkspaceServiceFactory [<Composition.ImportingConstructor>]
                                         nameof enableBackgroundItemKeyStoreAndSemanticClassification,
                                         enableBackgroundItemKeyStoreAndSemanticClassification
                                         nameof captureIdentifiersWhenParsing, captureIdentifiersWhenParsing
+                                        nameof solutionCrawler, solutionCrawler
                                     |],
                                     TelemetryThrottlingStrategy.NoThrottling
                                 )
@@ -423,28 +427,23 @@ type internal FSharpLanguageService(package: FSharpPackage) =
     override _.Initialize() =
         base.Initialize()
 
-        let globalOptions =
-            package
-                .ComponentModel
-                .DefaultExportProvider
-                .GetExport<FSharpGlobalOptions>()
-                .Value
+        let exportProvider = package.ComponentModel.DefaultExportProvider
+        let globalOptions = exportProvider.GetExport<FSharpGlobalOptions>().Value
 
-        globalOptions.BlockForCompletionItems <- false
-        globalOptions.SetBackgroundAnalysisScope(openFilesOnly = true)
+        let workspace = package.ComponentModel.GetService<VisualStudioWorkspace>()
 
-        let globalOptions =
-            package
-                .ComponentModel
-                .DefaultExportProvider
-                .GetExport<FSharpGlobalOptions>()
-                .Value
+        let solutionAnalysis =
+            workspace
+                .Services
+                .GetService<EditorOptions>()
+                .Advanced
+                .SolutionBackgroundAnalysis
 
-        globalOptions.BlockForCompletionItems <- false
+        globalOptions.SetBackgroundAnalysisScope(openFilesOnly = not solutionAnalysis)
 
-        let theme =
-            package.ComponentModel.DefaultExportProvider.GetExport<ISetThemeColors>().Value
+        globalOptions.BlockForCompletionItems <- false
 
+        let theme = exportProvider.GetExport<ISetThemeColors>().Value
         theme.SetColors()
 
     override _.ContentTypeName = FSharpConstants.FSharpContentTypeName

diff --git a/vsintegration/src/FSharp.Editor/Options/EditorOptions.fs b/vsintegration/src/FSharp.Editor/Options/EditorOptions.fs
@@ -114,6 +114,7 @@ type AdvancedOptions =
         IsInlineReturnTypeHintsEnabled: bool
         IsLiveBuffersEnabled: bool
         SendAdditionalTelemetry: bool
+        SolutionBackgroundAnalysis: bool
     }
 
     static member Default =
@@ -125,6 +126,7 @@ type AdvancedOptions =
             IsInlineReturnTypeHintsEnabled = false
             IsLiveBuffersEnabled = FSharpExperimentalFeaturesEnabledAutomatically
             SendAdditionalTelemetry = true
+            SolutionBackgroundAnalysis = false
         }
 
 [<CLIMutable>]

diff --git a/vsintegration/src/FSharp.UIResources/AdvancedOptionsControl.xaml b/vsintegration/src/FSharp.UIResources/AdvancedOptionsControl.xaml
@@ -42,6 +42,10 @@
                     <CheckBox x:Name="toggleSendAdditionalTelemetry" IsChecked="{Binding SendAdditionalTelemetry}"
                               Content="{x:Static local:Strings.Send_Additional_Telemetry}"/>
                 </GroupBox>
+                <GroupBox Header="{x:Static local:Strings.Background_analysis}">
+                    <CheckBox x:Name="toggleSolutionBackgroundAnalysis" IsChecked="{Binding SolutionBackgroundAnalysis}"
+                              Content="{x:Static local:Strings.Analyze_full_solution_on_background}"/>
+                </GroupBox>
             </StackPanel>
         </ScrollViewer>
     </Grid>

diff --git a/vsintegration/src/FSharp.UIResources/Strings.Designer.cs b/vsintegration/src/FSharp.UIResources/Strings.Designer.cs
diff --git a/vsintegration/src/FSharp.UIResources/Strings.resx b/vsintegration/src/FSharp.UIResources/Strings.resx
@@ -276,4 +276,10 @@
   <data name="Show_Return_Type_Hints" xml:space="preserve">
     <value>Display return type hints (preview)</value>
   </data>
+  <data name="Analyze_full_solution_on_background" xml:space="preserve">
+    <value>Keep analyzing the entire solution for diagnostics as a low priority background task (requires restart)</value>
+  </data>
+  <data name="Background_analysis" xml:space="preserve">
+    <value>Background analysis</value>
+  </data>
 </root>
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.cs.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.cs.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.de.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.de.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.es.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.es.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.fr.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.fr.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.it.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.it.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.ja.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.ja.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.ko.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.ko.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.pl.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.pl.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.pt-BR.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.pt-BR.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.ru.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.ru.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.tr.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.tr.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.zh-Hans.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.zh-Hans.xlf
diff --git a/vsintegration/src/FSharp.UIResources/xlf/Strings.zh-Hant.xlf b/vsintegration/src/FSharp.UIResources/xlf/Strings.zh-Hant.xlf