Revert correct Meter name #5403
Conversation
|
Fixes #5404 |
|
@dotnet-policy-service agree |
|
Hi @gitmln, Thank you for your contribution! Could you please add unit tests for the change made? We would like to avoid repeating this bug in the future. |
...soft.Extensions.Diagnostics.ResourceMonitoring.Tests/Windows/WindowsSnapshotProviderTests.cs
Show resolved
Hide resolved
| @@ -155,4 +157,15 @@ public void Provider_Returns_MemoryConsumption() | |||
| var usage = WindowsSnapshotProvider.GetMemoryUsageInBytes(); | |||
| Assert.InRange(usage, 0, long.MaxValue); | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
Should be [ConditionalFact] to support run on a certain platform only
There was a problem hiding this comment.
It turns out that all tests for WindowsContainerSnapshotProvider support running on Linux/MacOS. In fact, as I checked a pipeline, they are being executed on Ubuntu without a problem:
Question is should they? But I think this out of scope of this PR.
There was a problem hiding this comment.
Good observation.
No, that's no correct. The Windows-specific tests should have the following decoration:
[OSSkipCondition(OperatingSystems.Linux | OperatingSystems.MacOSX, SkipReason = "Windows specific tests")]
|
/backport to release/8.9 |
|
Started backporting to release/8.9: https://github.com/dotnet/extensions/actions/runs/10741673708 |
Fixes #5404
Corrects a bug with wrong meter name that has been changed from Microsoft.Extensions.Diagnostics.ResourceMonitoring to ResourceMonitoring
Microsoft Reviewers: Open in CodeFlow