Make capping happen after scale of the CPU usage in ResourceUtilization #5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree company="Microsoft" |
|
@Weikai1997 thanks for taking care of this. Could you please also add one or more tests such that they were failing before but won't be failing with your fix? |
|
@evgenyfedorov2 test added |
test/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Tests/CalculatorTests.cs
Outdated
Show resolved
Hide resolved
test/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Tests/CalculatorTests.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Aug 29, 2024
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Calculator.cs
Outdated
Show resolved
Hide resolved
test/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Tests/CalculatorTests.cs
Outdated
Show resolved
Hide resolved
test/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Tests/CalculatorTests.cs
Outdated
Show resolved
Hide resolved
|
@Weikai1997 thanks for the submission. |
RussKie
added
the
waiting-author-feedback 📭
dotnet-policy-service
bot
removed
the
waiting-author-feedback 📭
Weikai1997
changed the title
Weikai1997
changed the title
|
@RussKie Updated the PR title and the first post. Please tell me if more details need to add. Thanks |
RussKie
reviewed
Aug 29, 2024
test/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Tests/CalculatorTests.cs
Outdated
Show resolved
Hide resolved
evgenyfedorov2
approved these changes
Aug 29, 2024
|
We'll merge once the changes are validated and confirmed to have addressed the issue. |
RussKie
added
the
waiting-author-feedback 📭
|
The change was successfully verified. |
RussKie
removed
the
waiting-author-feedback 📭
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5387
The range of cpuUtilization we calculated from Snapshot in the Calculator is [0, 100*request]. We shouldn't capping the value to 100 in this step.
Instead, we should have the capping after we scale the utilization value to [0,100] by divide GuaranteedCpuUnits in the ResourceUtilization constructor.
Microsoft Reviewers: Open in CodeFlow