Move CultureInfoGenerator and CultureCache projects from Localization repo #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kirthik, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| // the framework to ensure your app works the same. | ||
| private static string CheckFor45DotVersion(int releaseKey) | ||
| { | ||
| if (releaseKey >= 393273) |
There was a problem hiding this comment.
Can we update this to whatever .NET 4.6 RTM uses?
|
I think the new packages need to be added to https://github.com/aspnet/Common/blob/dev/NuGetPackageVerifier.json as well. Contact @ajaybhargavb if you need help with this. I think both the new packages are "non-shipping". |
|
Once we implement aspnet/Localization#111, this PR is not relevant. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CultureInfoListis used in bothLocalizationandDNXrepos. Hence moving to this repo.cc @Eilon