Reset database object during the Dispose method #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem like an appropriate solution. In general nulling out fields in Dispose leads to race conditions and null reference exceptions. The assumption in #3531 that you should be able to call Dispose to disconnect and then call other methods and have it reconnect does not match the proper use of the Dispose pattern. Proposal: Dispose should set an internal _disposed bool field and any APIs called after should check that field and throw ObjectDisposedException. |
|
What do you think about this dotnet/runtime#42183 |
|
Unnecessary. |
|
Hello @Tratcher! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Nov 17, 2020
* Reset database object during the Dispose method * Throw ObjectDisposedException when object has already disposed\n\nCommit migrated from dotnet/extensions@6683bac
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset database object during the Dispose method
Fixes #3531
Please review,
Thank you in advance