Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use even more Arcade and other csproj cleanups #1833

Merged
merged 9 commits into from
Jun 13, 2019
Merged

Use even more Arcade and other csproj cleanups #1833

merged 9 commits into from
Jun 13, 2019

Conversation

natemcmaster
Copy link

This removes dead code and some of the workarounds we originally put in place to minimize the changes required to adopt Arcade in this repo.

Changes:

  • Arcade's default for IsPackable is false, and that .csproj files should explicitly opt-in to producing packages. I've updated all .csproj files to use this. This is a safer default which helps us avoid accidentally shipping packages we didn't mean to.
  • Version settings go in eng/Versions.props
  • Instead of IsFinalBuild, use p:DotNetFinalVersionKind
  • Other cleanups, like removing files that were only used by KoreBuild and updating README

@natemcmaster natemcmaster requested review from analogrelay, dougbu, Tratcher and a team as code owners June 13, 2019 00:04
@natemcmaster natemcmaster merged commit f12d709 into master Jun 13, 2019
@ghost ghost deleted the namc/cleanup branch June 13, 2019 05:39
@analogrelay analogrelay added this to the 3.0.0-preview7 milestone Jun 13, 2019
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 12, 2020
@natemcmaster
Use even more Arcade and other csproj cleanups (dotnet/extensions#1833)
4599271 
* Use Arcade's convention for setting IsPackable (must be explicitly set)
* Use Arcade conventions for using DebugType and eng/Versions.props
* Remove dead code
* Update restore feeds in daily builds.md
* Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests
* Remove usage of TestGroupName (an obsolete KoreBuild setting)
* Use IVT as a .csproj attribute

\n\nCommit migrated from dotnet/extensions@f12d709
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 15, 2020
@natemcmaster
Use even more Arcade and other csproj cleanups (dotnet/extensions#1833)
5868b65 
* Use Arcade's convention for setting IsPackable (must be explicitly set)
* Use Arcade conventions for using DebugType and eng/Versions.props
* Remove dead code
* Update restore feeds in daily builds.md
* Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests
* Remove usage of TestGroupName (an obsolete KoreBuild setting)
* Use IVT as a .csproj attribute

\n\nCommit migrated from dotnet/extensions@f12d709
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020
@natemcmaster
Use even more Arcade and other csproj cleanups (dotnet/extensions#1833)
35c9fc5 
* Use Arcade's convention for setting IsPackable (must be explicitly set)
* Use Arcade conventions for using DebugType and eng/Versions.props
* Remove dead code
* Update restore feeds in daily builds.md
* Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests
* Remove usage of TestGroupName (an obsolete KoreBuild setting)
* Use IVT as a .csproj attribute



Commit migrated from dotnet/extensions@f12d709
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020
@natemcmaster
Use even more Arcade and other csproj cleanups (dotnet/extensions#1833)
a4e0f64 
* Use Arcade's convention for setting IsPackable (must be explicitly set)
* Use Arcade conventions for using DebugType and eng/Versions.props
* Remove dead code
* Update restore feeds in daily builds.md
* Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests
* Remove usage of TestGroupName (an obsolete KoreBuild setting)
* Use IVT as a .csproj attribute



Commit migrated from dotnet/extensions@f12d709
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@natemcmaster
Use even more Arcade and other csproj cleanups (dotnet/extensions#1833)
d070cbe 
* Use Arcade's convention for setting IsPackable (must be explicitly set)
* Use Arcade conventions for using DebugType and eng/Versions.props
* Remove dead code
* Update restore feeds in daily builds.md
* Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests
* Remove usage of TestGroupName (an obsolete KoreBuild setting)
* Use IVT as a .csproj attribute



Commit migrated from dotnet/extensions@f12d709
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@natemcmaster
Use even more Arcade and other csproj cleanups (dotnet/extensions#1833)
11bf2e9 
* Use Arcade's convention for setting IsPackable (must be explicitly set)
* Use Arcade conventions for using DebugType and eng/Versions.props
* Remove dead code
* Update restore feeds in daily builds.md
* Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests
* Remove usage of TestGroupName (an obsolete KoreBuild setting)
* Use IVT as a .csproj attribute



Commit migrated from dotnet/extensions@f12d709
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 17, 2020
@natemcmaster
Use even more Arcade and other csproj cleanups (dotnet/extensions#1833)
3b86e56 
* Use Arcade's convention for setting IsPackable (must be explicitly set)
* Use Arcade conventions for using DebugType and eng/Versions.props
* Remove dead code
* Update restore feeds in daily builds.md
* Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests
* Remove usage of TestGroupName (an obsolete KoreBuild setting)
* Use IVT as a .csproj attribute



Commit migrated from dotnet/extensions@f12d709
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 25, 2020
@natemcmaster
Use even more Arcade and other csproj cleanups (dotnet/extensions#1833)
5c2e876 
* Use Arcade's convention for setting IsPackable (must be explicitly set)
* Use Arcade conventions for using DebugType and eng/Versions.props
* Remove dead code
* Update restore feeds in daily builds.md
* Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests
* Remove usage of TestGroupName (an obsolete KoreBuild setting)
* Use IVT as a .csproj attribute



Commit migrated from dotnet/extensions@f12d709
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020
@natemcmaster
Use even more Arcade and other csproj cleanups (dotnet/extensions#1833)
ce6d79a 
* Use Arcade's convention for setting IsPackable (must be explicitly set)
* Use Arcade conventions for using DebugType and eng/Versions.props
* Remove dead code
* Update restore feeds in daily builds.md
* Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests
* Remove usage of TestGroupName (an obsolete KoreBuild setting)
* Use IVT as a .csproj attribute



Commit migrated from dotnet/extensions@f12d709
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Nov 17, 2020
@natemcmaster
Use even more Arcade and other csproj cleanups (dotnet/extensions#1833)
d6ca904 
* Use Arcade's convention for setting IsPackable (must be explicitly set)
* Use Arcade conventions for using DebugType and eng/Versions.props
* Remove dead code
* Update restore feeds in daily builds.md
* Disable UsingToolNetFrameworkReferenceAssemblies in analyzer tests
* Remove usage of TestGroupName (an obsolete KoreBuild setting)
* Use IVT as a .csproj attribute

\n\nCommit migrated from dotnet/extensions@f12d709
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dougbu dougbu dougbu approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@Tratcher Tratcher Awaiting requested review from Tratcher Tratcher is a code owner

Assignees

@JunTaoLuo JunTaoLuo

Labels
None yet
Projects
None yet
Milestone
3.0.0-preview7
Development

Successfully merging this pull request may close these issues.
4 participants
@natemcmaster @dougbu @analogrelay @JunTaoLuo