RevEng: Use unbound NavProps on the IModel instead of annotations #5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RelationalScaffoldingModelFactory and then drawing the names directly from there which allows us to stop using the ScaffoldingForeignKeyAnnotations altogether.
|
Note for provider-writers: if you previously were using |
| var principalEndNavigationPropertyName = | ||
| foreignKey.Scaffolding().PrincipalEndNavigation; | ||
| var dependentEndNavigationPropertyName = foreignKey.DependentToPrincipal.Name; | ||
| var principalEndNavigationPropertyName = foreignKey.PrincipalToDependent.Name; |
There was a problem hiding this comment.
null check for navigations needed?
There was a problem hiding this comment.
@smitpatel Will do. After that can I convert the LGTM to a ship-it?
|
LGTM. |
|
If someone else wants to review otherwise |
|
Checked in with commit 767b3dd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5154. This is clean up - no change to output from Scaffolding. Now that you can add "shadow" NavProps to an
IModelwe make use of them so we can stop using the artificialScaffoldingForeignKeyAnnotations.Change to
ForeignKeyis just cleaning up a whitespace problem I saw when I was doing this.