[release/9.0] Fix Cosmos enum partition keys #34922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34911
Description
Among the many changes done to the Cosmos provider in 9.0, the logic for handling partition keys was rewritten; the new logic fails to handle enum constants properly - these require special handling because of how the C# compiler produces expression trees around enums.
Customer impact
When an enum property is used as a partition key, queries filtering on that property fail to execute (this is expected to be a relatively common scenario).
How found
Customer reported on 9.0.0-rc.2
Regression
Yes
Testing
Added.
Risk
Very low.