Rewrite SearchConditionConverter #34905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current SearchConditionConvertingExpressionVisitor has the following design issues:
_isSearchCondition
can be set to false before visiting (and set back at the end).This rewrite changes the design as follows:
This is similar to #34697, which changed SqlNullabillityProcessor into a real visitor, allowing VisitChildren to be used (for non-SqlExpression expressions).
/cc @ranma42