[release/9.0] Nanoseconds and microseconds processing fix on Cosmos #34901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Oct 14, 2024
|
approved via email |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #34861. For Cosmos only because Cosmos already had the support.
Description
In Cosmos provider for EF Core 9 we improperly translated
NanosecondandMicrosecondproperties leading into mismatch between expected .NET behavior and what was actually done in database. This is a new functionality in 9.0.Customer impact
Incorrect data returned from query. Possible data corruption bug.
How found
Found while implementing same support for SQL Server.
Regression
No.
Testing
Tests added (in
maincovering bigger area).Risk
Low.