Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RC2) Fix ESCAPE clause for Azure Synapse. (#34463) #34509

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

cincuranet
Copy link
Contributor

@cincuranet cincuranet commented Aug 22, 2024

Port of #34463
Port of #34506

Fixes #33555

Description

Fixes translation of Contains/StartsWith/EndsWith into SQL on Azure Synapse.

Customer impact

Customers using Azure Synapse are unable to run queries using Contains/StartsWith/EndsWith because improper SQL is generated.

How found

Reported by customer.

Regression

Yes, in 8.0.

Testing

Tests added.

Risk

Low.

@cincuranet cincuranet requested review from artl93 and a team August 22, 2024 10:13
@roji
Copy link
Member

roji commented Aug 22, 2024

Maybe just include into #34508? Otherwise this is lacking the template and the M2 ping.

@cincuranet cincuranet changed the title [release/9.0] Use different store names for funky data tests (#34506) (RC2) Use different store names for funky data tests (#34506) Aug 22, 2024
@cincuranet cincuranet changed the title (RC2) Use different store names for funky data tests (#34506) (RC2) Fix ESCAPE clause for Azure Synapse. (#34463) and Use different store names for funky data tests (#34506) Aug 22, 2024
@cincuranet cincuranet marked this pull request as ready for review August 22, 2024 12:02
@cincuranet cincuranet changed the title (RC2) Fix ESCAPE clause for Azure Synapse. (#34463) and Use different store names for funky data tests (#34506) (RC2) Fix ESCAPE clause for Azure Synapse. (#34463) Aug 22, 2024
@roji
Copy link
Member

roji commented Aug 22, 2024

/cc @artl93

@cincuranet cincuranet merged commit 7757168 into dotnet:main Aug 22, 2024
7 checks passed
@cincuranet cincuranet deleted the backport-funky-store-names branch August 22, 2024 12:44
@cincuranet
Copy link
Contributor Author

This went into wrong branch (main so it's actually empty commit and nothing is broken). #34510 is correct PR.

@roji
Copy link
Member

roji commented Aug 22, 2024

Ah, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StartsWith/EndsWith/Contains with parameter fails on Azure Synapse because ESCAPE isn't supported there
2 participants