Merging internal commits for release/8.0 #34425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet-runtime build 20240716.12 Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport From Version 8.0.7-servicing.24313.11 -> To Version 8.0.8-servicing.24366.12
…ng/internal/dotnet-runtime This pull request updates the following dependencies [marker]: <> (Begin:922981e1-18b6-46aa-2468-08dbd53ba9ce) ## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime - **Subscription**: 922981e1-18b6-46aa-2468-08dbd53ba9ce - **Build**: 20240716.12 - **Date Produced**: July 16, 2024 10:31:44 PM UTC - **Commit**: 08338fcaa5c9b9a8190abb99222fed12aaba956c - **Branch**: refs/heads/internal/release/8.0 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.Extensions.HostFactoryResolver.Sources**: [from 8.0.7-servicing.24313.11 to 8.0.8-servicing.24366.12][1] - **Microsoft.NETCore.App.Ref**: [from 8.0.7 to 8.0.8][1] - **Microsoft.NETCore.App.Runtime.win-x64**: [from 8.0.7 to 8.0.8][1] - **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 8.0.7-servicing.24313.11 to 8.0.8-servicing.24366.12][1] [1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC2aade6beb02ea367fd97c4070a4198802fe61c03&targetVersion=GC08338fcaa5c9b9a8190abb99222fed12aaba956c&_a=files [DependencyUpdate]: <> (End) [marker]: <> (End:922981e1-18b6-46aa-2468-08dbd53ba9ce)
Temporarily work around '/' in dSAS When dSAS tokens contain a forward /, helix will incorrectly name the file target for a correlation payload, and then fail to unpack it. ---- #### AI description (iteration 1) #### PR Classification Bug fix to address an issue with SAS tokens containing '/' causing incorrect downloads. #### PR Summary This pull request implements a workaround for a Helix issue where SAS tokens with '/' result in incorrect downloads of correlation payloads. - `eng/common/templates/steps/get-delegation-sas.yml`: Added a loop to regenerate the SAS token if it contains a '/' character, ensuring valid tokens are generated.
Temporarily work around '/' in dSAS When dSAS tokens contain a forward /, helix will incorrectly name the file target for a correlation payload, and then fail to unpack it. ---- #### AI description (iteration 1) #### PR Classification Bug fix to address an issue with SAS tokens containing '/' causing incorrect downloads. #### PR Summary This pull request implements a workaround for a Helix issue where SAS tokens with '/' result in incorrect downloads of correlation payloads. - `eng/common/templates-official/steps/get-delegation-sas.yml`: Added a loop to regenerate SAS tokens until one without '/' is obtained.
…-merge-8.0-2024-08-13-1057-dda3cfbb-439d-49b9-80ee-fe43cf6f662f
AndriySvyryd
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.