SQL Server: Use bitwise NOT on BIT expressions
#34303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently only supported in the final part of SqlServer translation pipeline.
Instead of `x ^ 1`, use the `~x` expression when translating boolean values in SqlServer.
ranma42
force-pushed
the
sqlserver-bitwise-not
branch
from
2e71cc8
to
5cfd67a
Compare
maumar
approved these changes
Jul 29, 2024
|
nice! thanks @ranma42 |
roji
changed the title
BIT SqlServer expressionsBIT expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #34080 the SqlServer provider uses XOR to avoid converting to/from predicates when negating BIT expressions.
It is actually possible to simply use
~onBITvalues and this changeset implements this.Fixes #34213