Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate suppressible error when entity saved to Cosmos without PK value set #34250

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

ajcvickers
Copy link
Member

Fixes #34180

We throw if there is no property in the primary key that is not generated and does not have a value set, excluding partition key properties.

@ajcvickers ajcvickers requested a review from a team July 19, 2024 15:03
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See mainly simple implementation notes

…lue set

Fixes #34180

We throw if there is no property in the primary key that is not generated and does not have a value set, excluding partition key properties.
@ajcvickers ajcvickers merged commit b357c75 into main Jul 22, 2024
7 checks passed
@ajcvickers ajcvickers deleted the HotFridayDeals branch July 22, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmos: warn when attempting to save entity with CLR default key value
2 participants