Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API review updates #34241

Merged
merged 1 commit into from
Jul 18, 2024
Merged

API review updates #34241

merged 1 commit into from
Jul 18, 2024

Conversation

ajcvickers
Copy link
Member

Part of #33220

  • Replace IUpdateEntry.GetOriginalOrCurrentValue with HasOriginalValue
  • Review MigrationsSqlGenerator.KeyWithOptions - no longer exists
  • Rename TConcreteCollection to TConcreteList for ListOf*Comparer
  • Consider sealing JsonCollection*ReaderWriter classes - considered, but decided against it.
  • Obsolete the old CosmosQueryableExtensions.WithPartitionKey overload - Overload resolution picks the obsolete method, so better not to make it obsolete otherwise it is a pain (explicit cast needed) for people attempting to try to use the new method instead of the obsolete one.
  • Ensure PartitionKey is appropriate for diagnostics
  • Remove EntityMaterializerSource from QueryContext and QueryContextDependencies

@ajcvickers
API review updates
aa8fd59 
Part of #33220

-  Replace `IUpdateEntry.GetOriginalOrCurrentValue` with `HasOriginalValue`
- Review `MigrationsSqlGenerator.KeyWithOptions` - no longer exists
- Rename `TConcreteCollection` to `TConcreteList` for ListOf*Comparer
- Consider sealing JsonCollection*ReaderWriter classes - considered, but decided against it.
- Obsolete the old CosmosQueryableExtensions.WithPartitionKey overload - Overload resolution picks the obsolete method, so better not to make it obsolete otherwise it is a pain (explicit cast needed) for people attempting to try to use the new method instead of the obsolete one.
- Ensure PartitionKey is appropriate for diagnostics
-  Remove EntityMaterializerSource from QueryContext and QueryContextDependencies
@ajcvickers ajcvickers requested a review from a team July 17, 2024 15:08
@ajcvickers ajcvickers merged commit 594688b into main Jul 18, 2024
7 checks passed
@ajcvickers ajcvickers deleted the HapiApi branch July 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cincuranet cincuranet cincuranet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajcvickers @cincuranet