Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute migrations using the ExecutionStrategy #34206

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Execute migrations using the ExecutionStrategy #34206

merged 2 commits into from
Jul 26, 2024

Conversation

AndriySvyryd
Copy link
Member

Use a single transaction for all migrations in the script

Fixes #17578
Fixes #22616

@AndriySvyryd AndriySvyryd requested a review from a team July 11, 2024 01:08
@AndriySvyryd
Copy link
Member Author

Only review the last commit

@AndriySvyryd
Add extension point to Migrate
69bcb92 
Allow to specify a target migration in Migrate call
Warn on Migrate when there are pending model changes

Fixes #17568
Fixes #33732
Fixes #34196
@AndriySvyryd
Execute migrations using the ExecutionStrategy
4697720 
Use a single transaction for all migrations in the script

Fixes #17578
Fixes #22616
@AndriySvyryd AndriySvyryd enabled auto-merge (rebase) July 16, 2024 01:12
roji
roji approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviews 2nd commit only, LGTM but see comments.

src/EFCore.Relational/Migrations/Internal/MigrationCommandExecutor.cs Show resolved Hide resolved
src/EFCore.Relational/Migrations/Internal/MigrationCommandExecutor.cs Show resolved Hide resolved
src/EFCore.Relational/Migrations/Internal/MigrationCommandExecutor.cs Show resolved Hide resolved
src/EFCore.Relational/Migrations/Internal/MigrationCommandExecutor.cs Show resolved Hide resolved
src/EFCore.Relational/Migrations/Internal/MigrationCommandExecutor.cs Show resolved Hide resolved
@AndriySvyryd AndriySvyryd merged commit 3d6868e into main Jul 26, 2024
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue17578 branch July 26, 2024 21:22
@roji
Copy link
Member

roji commented Jul 26, 2024

Ah, my bad - forgot to clear auto-merge before approving. @AndriySvyryd take a look at the comments above.

This was referenced Jul 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop all migrations and roll back everything on failure Execution strategy for migration
2 participants
@AndriySvyryd @roji