Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce UseAzureSynapse and UseAzureSql #34052

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Conversation

cincuranet
Copy link
Contributor

Fixes #33816

@cincuranet cincuranet changed the title Synapse Introduce UseAzureSynapse and UseAzureSql Jun 21, 2024
@cincuranet cincuranet force-pushed the synapse branch 5 times, most recently from 999b12d to 62a7928 Compare June 25, 2024 11:59
@cincuranet cincuranet marked this pull request as ready for review June 25, 2024 17:57
@cincuranet cincuranet requested a review from a team June 25, 2024 17:57
@AndriySvyryd
Copy link
Member

AndriySvyryd commented Jul 11, 2024

@cincuranet Let me know once this is ready for review again

@cincuranet
Copy link
Contributor Author

@AndriySvyryd This should be now ready for review.

@cincuranet cincuranet merged commit 16ea450 into dotnet:main Aug 6, 2024
7 checks passed
@cincuranet cincuranet deleted the synapse branch August 6, 2024 06:42
@AndriySvyryd
Copy link
Member

Looking at this again I find it confusing that you can call .UseSqlServer(b => UseAzureSqlCompatibilityLevel())
Each of the Use* methods should accept a different builder type, then they each could just have a UseCompatibilityLevel method that corresponds to the target engine.
Additionally, for ConfigureSqlEngine the builder should have a non-obsolete method that enables a retrying execution strategy if one wasn't configured (I don't remember what we decided to name this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce UseAzureSql/UseAzureSynapse as alternatives to UseSqlServer
2 participants