Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement translation of HashSet<T> (and ICollection<T> in general) to OPENJSON query #33920

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Implement translation of HashSet<T> (and ICollection<T> in general) to OPENJSON query #33920

merged 1 commit into from
Jun 10, 2024

Conversation

cincuranet
Copy link
Contributor

Fixes #32365.

@cincuranet cincuranet requested review from maumar and roji June 6, 2024 08:31
@cincuranet
Copy link
Contributor Author

cincuranet commented Jun 6, 2024 •
edited
Loading

I added only one new test Parameter_collection_HashSet_of_ints_Contains_int. Do we want to add variations with HashSet<T> for every Parameter_collection_xxx test we have? The translation would be same as for i.e. array, it is just what's the input collection.

@cincuranet cincuranet force-pushed the hashset branch 2 times, most recently from 8a74b8e to 841d95f Compare June 6, 2024 09:16
@maumar
Copy link
Contributor

maumar commented Jun 7, 2024

I think we should be fine as is, test-wise

@cincuranet cincuranet merged commit 60d2d8e into dotnet:main Jun 10, 2024
7 checks passed
@cincuranet cincuranet deleted the hashset branch June 10, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maumar maumar maumar approved these changes

@roji roji Awaiting requested review from roji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hashset contains becomes a traditional IN statement instead of the new OpenJSON parameter
2 participants
@cincuranet @maumar