Clean up query translator/expression namespace and file placement #33782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33755 moved query translator into their own folder, and with the namespace was e.g. Microsoft.EntityFrameworkCore.Cosmos.Query.Internal.Translators; but our analyzer identifies internal namespaces as ending with Internal. Since the main idea here was file placement, I just changed the namespace back to Microsoft.EntityFrameworkCore.Cosmos.Query.Internal (sorry for the churn).
Also did the same with all expression inside provider projects - they're now grouped under their own directories, but keeping the general Microsoft.EntityFrameworkCore.Cosmos.Query.Internal namespace.
Relational is unfortunately a bit of a mess; some expressions are already grouped under an SqlExpressions directory - although many expressions there don't extend SqlExpression (e.g. SelectExpression). Some other expressions are at the query root instead :( Changing namespaces here would be a breaking change; we can still move the files instead just for cleanliness but keep the namespace (or maybe there's some classification system here I didn't notice, @maumar).