Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement average aggregation for decimal in SQLite #33720

Closed
wants to merge 3 commits into from

Conversation

ranma42
Copy link
Contributor

@ranma42 ranma42 commented May 15, 2024

Contributes to #19635

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber

(well, "Contributes" instead of "Fixes")

  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@ranma42 ranma42 marked this pull request as draft May 15, 2024 05:48
@ranma42 ranma42 changed the title Implement sum aggregation for decimal in SQLite Implement average aggregation for decimal in SQLite May 15, 2024
@ranma42
Copy link
Contributor Author

ranma42 commented May 15, 2024

I also posted #33721. This PR is slightly simpler as it does not affect the nullability processing, but I left it as a draft as I still have some (similar) doubts around both these changesets. I'll update both PRs later on 😇

@roji
Copy link
Member

roji commented May 15, 2024

@ranma42 I'd suggest submitting a single PR for the multiple aggregate translations; things are similar enough that it makes sense to just have a single PR I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants