OTEL implementation, so far matching EventCounters infrastructure. #33633
Conversation
|
@cincuranet @SamMonoRT I know I'm behind on reviewing this, it's high on my list and moving up - early next week for sure. |
|
@cincuranet I just noticed I was marked as a reviewer on this PR. Is there any specific input you'd like me to provide? I don't have a ton of context on efcore. |
Was mostly if you saw patterns from other Aspire OTEL efforts. |
...Core.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.QueryingEnumerable.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Tests/Infrastructure/Internal/EntityFrameworkMetricsDataTest.cs
Outdated
Show resolved
Hide resolved
cincuranet
force-pushed
the
otel
branch
2 times, most recently
from
9496e4a
to
020f63d
Compare
|
@cincuranet answered some questions above. |
....InMemory/Query/Internal/InMemoryShapedQueryCompilingExpressionVisitor.QueryingEnumerable.cs
Show resolved
Hide resolved
cincuranet
force-pushed
the
otel
branch
2 times, most recently
from
ed07c62
to
01c6e19
Compare
|
Could you also add documentation about these counters to https://learn.microsoft.com/en-us/dotnet/core/diagnostics/built-in-metrics please? :) Those docs are a major way for customers to discover what metrics the .NET platform is providing to them. |
|
@noahfalk WILCO |
|
Thanks! 👍 |
Fixes #25880