Transform JSON_VALUE() to OPENJSON/WITH for binary/varbinary #33440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
changed the title
roji
force-pushed
the
JsonValueOpenjson
branch
2 times, most recently
from
cb2e6fe
to
fe5a512
Compare
|
@maumar @cincuranet this PR is restricted specifically to solving the binary/varbinary problem - I'm leaving other things (like big >4000 strings) for discussion/research in #30981. The "infra" introduced in this PR can easily be used to convert JSON_VALUE() -> OPENJSON() for other types as well, if we want to do that. |
cincuranet
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transforms JSON_VALUE() into OPENJSON() in postprocessing for JSON binary/varbinary properties, applying base64 decoding to the data coming out of JSON and properly converting it to SQL Server binary/varbinary. I can't say I'm happy with SQL Server making us jump through all these hoops, but at least our query infrastructure now makes it pretty nice and easy to do this kind of stuff...
Note that this PR only handles binary/varbinary; other cases where we may want to transform JSON_VALUE() to OPENJSON() (e.g.
nvarchar(max)) aren't handled and are still tracked by #30981.Closes #33435
/cc @maumar @cincuranet