Only use length-based sized type inference for string concat #33403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
approved these changes
Mar 26, 2024
roji
approved these changes
Mar 26, 2024
| @@ -274,6 +279,9 @@ private SqlExpression ApplyTypeMappingOnLike(LikeExpression likeExpression) | |||
| ApplyTypeMapping(right, inferredTypeMapping), | |||
| resultType, | |||
| resultTypeMapping); | |||
|
|
|||
| static bool IsForString(RelationalTypeMapping? typeMapping) | |||
| => (typeMapping?.Converter?.ProviderClrType ?? typeMapping?.ClrType) == typeof(string); | |||
There was a problem hiding this comment.
Unrelated to this PR, but we should really have an API on type mapping that does this - feels like I've written/seen this code lots of times already.
There was a problem hiding this comment.
I was thinking the same thing, but I know I looked at it in the past and didn't add sugar for some reason.
test/EFCore.Specification.Tests/Query/AdHocMiscellaneousQueryTestBase.cs
Outdated
Show resolved
Hide resolved
As opposed to when an `Add` note is for something other than concatenation. Fixes #33330
ajcvickers
force-pushed
the
240326_AddManAdd
branch
from
0b4313e
to
5760ace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opposed to when an
Addnote is for something other than concatenation.Fixes #33330