Return flattened properties of complex types in correct order #33393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #33307 Property indexes are created such that properties of derived types are at the end--it has to be this way so that the indexes for properties on the base type remain the same for all derived types. However, when getting the flattened properties, we were returning them in a different order, such that properties with indexes for inherited type were returned in the middle of the list. This change instead returns the properties in the same order as their indexes.
cincuranet
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33307
Property indexes are created such that properties of derived types are at the end--it has to be this way so that the indexes for properties on the base type remain the same for all derived types. However, when getting the flattened properties, we were returning them in a different order, such that properties with indexes for inherited type were returned in the middle of the list. This change instead returns the properties in the same order as their indexes.