Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API review changes #33221

Merged
merged 1 commit into from
Mar 4, 2024
Merged

API review changes #33221

merged 1 commit into from
Mar 4, 2024

Conversation

AndriySvyryd
Copy link
Member

Part of #33220

@AndriySvyryd AndriySvyryd requested a review from a team March 1, 2024 21:05
@ajcvickers
Copy link
Member

What is the behavior for a value comparer on a navigation? When do we use this?

@AndriySvyryd
Copy link
Member Author

AndriySvyryd commented Mar 4, 2024 •
edited
Loading

What is the behavior for a value comparer on a navigation?

I am assuming that you are referring to IComparer<IUpdateEntry> GetCurrentValueComparer().
It will throw, unless the navigation type is comparable. I am just reverting to EF 8 API.

When do we use this?

Never for navigations. We use it to compare key values for the secondary order for modification commands

@AndriySvyryd AndriySvyryd merged commit c2c764c into main Mar 4, 2024
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue33220 branch March 4, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndriySvyryd @ajcvickers