Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup duplicate tests (same test ID) #33185

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Cleanup duplicate tests (same test ID) #33185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...e.Relational.Specification.Tests/Query/NorthwindKeylessEntitiesQueryRelationalTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ public virtual async Task Collection_of_entities_projecting_correlated_collectio
Assert.Equal(RelationalStrings.InsufficientInformationToIdentifyElementOfCollectionJoin, message);
}

[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]
public override async Task KeylessEntity_with_included_navs_multi_level(bool async)
{
var message = (await Assert.ThrowsAsync<InvalidOperationException>(
Expand All @@ -60,8 +58,6 @@ public override async Task KeylessEntity_with_included_navs_multi_level(bool asy
Assert.Equal(RelationalStrings.InsufficientInformationToIdentifyElementOfCollectionJoin, message);
}

[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]
public override async Task KeylessEntity_with_defining_query_and_correlated_collection(bool async)
{
var message = (await Assert.ThrowsAsync<InvalidOperationException>(
Expand Down
4 changes: 0 additions & 4 deletions ...FCore.Relational.Specification.Tests/Query/PrimitiveCollectionsQueryRelationalTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,9 @@ public override async Task Inline_collection_Count_with_zero_values(bool async)
Assert.Equal(RelationalStrings.EmptyCollectionNotSupportedAsInlineQueryRoot, exception.Message);
}

[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]
public override Task Column_collection_Concat_parameter_collection_equality_inline_collection(bool async)
=> AssertTranslationFailed(() => base.Column_collection_Concat_parameter_collection_equality_inline_collection(async));

[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]
public override Task Column_collection_equality_inline_collection_with_parameters(bool async)
=> AssertTranslationFailed(() => base.Column_collection_equality_inline_collection_with_parameters(async));

Expand Down
Loading