Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover the compiled model automatically #33148

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Discover the compiled model automatically #33148

merged 1 commit into from
Mar 14, 2024

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Feb 24, 2024 •
edited
Loading

Tests tracked by #33136

Fixes #24893
Fixes #33075

@AndriySvyryd AndriySvyryd requested a review from a team February 24, 2024 04:30
@AndriySvyryd AndriySvyryd force-pushed the Issue24893 branch 2 times, most recently from 1013976 to 6ee7141 Compare March 4, 2024 19:19
@AndriySvyryd
Copy link
Member Author

@dotnet/efteam Ping

SamMonoRT
SamMonoRT approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@SamMonoRT SamMonoRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ensure no CI failures.

@AndriySvyryd
Discover the compiled model automatically
1b33fb1 
Also add a way to manually reference the compiled model before it's generated

Tests tracked by #33136

Fixes #24893
@AndriySvyryd AndriySvyryd merged commit 5ce0b33 into main Mar 14, 2024
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue24893 branch March 14, 2024 21:34
@AndriySvyryd AndriySvyryd mentioned this pull request Mar 15, 2024
Open
@AndriySvyryd AndriySvyryd mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamMonoRT SamMonoRT SamMonoRT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider making compiled model tests more fine-grained Discover the compiled model automatically
2 participants
@AndriySvyryd @SamMonoRT