Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily build selection image. #32975

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Fix daily build selection image. #32975

merged 3 commits into from
Feb 1, 2024

Conversation

ajcvickers
Copy link
Member

@ajcvickers ajcvickers commented Jan 31, 2024

No description provided.

@ajcvickers ajcvickers requested a review from a team January 31, 2024 14:10
@@ -79,11 +79,11 @@ Using wildcards will cause NuGet to pull the latest daily build whenever package

You can use your IDE to choose the latest version. For example, in Visual Studio:

![image](![image](https://github.com/dotnet/efcore/assets/1430078/9a54546b-f969-4409-868b-0fa675b162c6))
![Pick the daily build to use inside your IDE.](usedaily.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to not have the image checked in, if possible.

Also, now it doesn't have the cool red marking to draw attention.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to not have the image checked in, if possible.

The GitHub automatic uploading has been causing issues. I can try again, or do you have a different idea where it could go?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can try using a different browser.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, obviously, I only have Edge installed.

Hello Google, my old friend
I've come to talk with you again
Because an image softly creeping
Lost its size while I was sleeping
And the image that was planted in my brain
Still remains
Within the sound of silence

@ajcvickers
Copy link
Member Author

@AndriySvyryd How's that? :-D

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection!

@ajcvickers ajcvickers merged commit a8b1664 into main Feb 1, 2024
7 checks passed
@ajcvickers ajcvickers deleted the HackThatCat branch February 1, 2024 09:25
roji pushed a commit to roji/efcore that referenced this pull request Feb 9, 2024
* Fix daily build selection image.

* Update DailyBuilds.md

* Remove image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants