Fix to #32939 - Accidentally using field instead of property for JSON metadata produce hard to understand exception #32966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Jan 31, 2024
...l/Query/RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
… metadata produce hard to understand exception When processing shaper for JSON streaming we didn't protect against the case where there are no properties on JSON entity that should be populated as part of the loop. Fix check the count of properties we found before we start generating Switch-Case statement for PropertyName. Fixes #32939
roji
pushed a commit
to roji/efcore
that referenced
this pull request
Feb 9, 2024
…r JSON metadata produce hard to understand exception (dotnet#32966) When processing shaper for JSON streaming we didn't protect against the case where there are no properties on JSON entity that should be populated as part of the loop. Fix check the count of properties we found before we start generating Switch-Case statement for PropertyName. Fixes dotnet#32939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing shaper for JSON streaming we didn't protect against the case where there are no properties on JSON entity that should be populated as part of the loop. Fix check the count of properties we found before we start generating Switch-Case statement for PropertyName.
Fixes #32939