Stop throwing eagerly when looking up a ValueGenerator #32930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The #32892 has been marked as a Servicing Consider 8.0.x label. The description above indicates this is a breaking change. |
|
@SamMonoRT We may want to do a somewhat less clean version of the fix that isn't a break when take this to the servicing branch. I would like to hear what the @dotnet/efteam thinks. |
|
I think we should still throw this for non-composite keys, as it would be a more useful exception than a "key not set" |
ajcvickers
force-pushed
the
240126_Length2933
branch
from
eee787c
to
a05f31d
Compare
|
@AndriySvyryd @SamMonoRT New version up that retains the behavior of throwing for non-composite keys. Also changed the break into an obsolete. We can't port this directly to release/8.0, but if this is the correct fix going forward, then I'll look at the port next. |
AndriySvyryd
reviewed
Feb 2, 2024
AndriySvyryd
approved these changes
Feb 2, 2024
Fixes #32892 The issue was introduced by the fix for stable/unstable values. In that fix, we were missing that a value generator exists and influences whether the generated value is considered stable or not. However, some types, most notably bools, don't have a default generator. This is fine, it just means that there isn't a generator to use. I removed the exception entirely because we never now throw if we can't find a generator--it's always okay. This is technically a breaking change, and people do create their own selectors, so we should probably doc it.
…e keys set for generation without any generator.
ajcvickers
force-pushed
the
240126_Length2933
branch
from
a05f31d
to
5cb7511
Compare
roji
pushed a commit
to roji/efcore
that referenced
this pull request
Feb 9, 2024
* Stop throwing eagerly when looking up a ValueGenerator Fixes dotnet#32892 The issue was introduced by the fix for stable/unstable values. In that fix, we were missing that a value generator exists and influences whether the generated value is considered stable or not. However, some types, most notably bools, don't have a default generator. This is fine, it just means that there isn't a generator to use. I removed the exception entirely because we never now throw if we can't find a generator--it's always okay. This is technically a breaking change, and people do create their own selectors, so we should probably doc it. * Update to remove the breaking change and still throw for non-composite keys set for generation without any generator. * Remove interface default implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32892
The issue was introduced by the fix for stable/unstable values. In that fix, we were missing that a value generator exists and influences whether the generated value is considered stable or not. However, some types, most notably bools, don't have a default generator. This is fine, it just means that there isn't a generator to use.
I removed the exception entirely because we never now throw if we can't find a generator--it's always okay. This is technically a breaking change, and people do create their own selectors, so we should probably doc it.