Updating Microsoft.CodeAnalysis version to 4.8 #32922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #32070 Whether or not this is a good idea depends on this table: https://learn.microsoft.com/visualstudio/extensibility/roslyn-version-support and whether or not we are okay with requiring VS 17.8 or later.
AndriySvyryd
approved these changes
Jan 25, 2024
|
Yeah, I think it's fine to require the latest VS given we target net8.0, which also requires it, right? I do remember that at some point our upgrade of these packages create issues on the VS side (which is maybe why we were reticent to upgrade afterwards), but that may have been a prerelease version - I don't remember any more. |
roji
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32070
Whether or not this is a good idea depends on this table: https://learn.microsoft.com/visualstudio/extensibility/roslyn-version-support
And whether or not we are okay with requiring VS 17.8 or later.