Fix incremental builds #32860
Merged
Fix incremental builds #32860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid writing to the obj directory unnecessarily to avoid tripping up the up-to-date check - Also fixes a subtle bug around file writing: File.OpenWrite will open an existing file and not truncate it, so if we ever write fewer bytes to that file than it currently contains, those additional bytes will be preserved, corrupting the file
ajcvickers
reviewed
Jan 27, 2024
ajcvickers
requested changes
Jan 27, 2024
ajcvickers
approved these changes
Jan 28, 2024
|
Thanks for the contribution! |
|
Nudges towards the double negation in the FileMatch check With this @ajcvickers , fyi |
|
@AlmightyLks Good catch! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File.OpenWritewill open an existing file and not truncate it, so if we ever write fewer bytes to that file than it currently contains, those additional bytes will remain at the end, corrupting the file. UsingFile.CreateorFile.WriteAllBytesensures the contents of the files are fully replaced.I hope this passes the "not too clever" bar and also improves reliability and performance.
Fixes #32801