Bubble up nullability for IN+subquery in SqlNullabilityProcessor #32849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
InSubqueryNullability
branch
2 times, most recently
from
09bf1d2
to
0ebde2d
Compare
roji
changed the title
maumar
approved these changes
Jan 22, 2024
roji
force-pushed
the
InSubqueryNullability
branch
from
0ebde2d
to
cc72bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To take a break from the heavier query architecture stuff, here's a small thing that improves null semantics rewriting for IN+subquery, doing full nullability analysis on the subquery projection, rather than the very shallow "if it's a column" thing we were doing before (and without double visitation).