Clean up and open table cloning logic #32665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
roji
force-pushed
the
ExpressionCloning
branch
from
9d1c308
to
64dba59
Compare
roji
force-pushed
the
ExpressionCloning
branch
from
64dba59
to
01a8584
Compare
maumar
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straightforward refactor, moving cloning logic out of the private CloningExpressionVisitor into Clone() methods on the various TableExpressionBase expressions. We already had an IClonableTableExpressionBase interface for extensibility, but its Clone() method did not accept the cloning visitor, so could not recursively visit sub-nodes. This opens things up and simplifies them.
Down the road I hope we can remove cloning altogether but for now it's a good idea to do this.
Fixes #30982
Fixes #32664