Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up KeyDiscoveryConvention #32650

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Break up KeyDiscoveryConvention #32650

merged 1 commit into from
Jan 4, 2024

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Dec 19, 2023 •
edited
Loading

Derive JsonTypesTestBase from NonSharedModelTestBase

Part of #28866

@AndriySvyryd AndriySvyryd requested a review from a team December 19, 2023 21:32
@AndriySvyryd AndriySvyryd force-pushed the Issue28866 branch 2 times, most recently from 75248be to 0679cf3 Compare December 20, 2023 07:28
@AndriySvyryd
Break up KeyDiscoveryConvention
80493be 
Derive JsonTypesTestBase from NonSharedModelTestBase

Part of #28866
@AndriySvyryd AndriySvyryd merged commit 2fb3cf2 into main Jan 4, 2024
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue28866 branch January 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndriySvyryd @ajcvickers