Fix to #1015 - Remove QueryBugsTest class #32542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
force-pushed
the
fix1015
branch
4 times, most recently
from
1669b59
to
d058ddf
Compare
AndriySvyryd
reviewed
Dec 8, 2023
test/EFCore.Specification.Tests/Query/AdHocRareMappingsQueryTestBase.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Dec 8, 2023
test/EFCore.Relational.Specification.Tests/Query/AdHocMiscellaneousQueryRelationalTestBase.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Dec 8, 2023
test/EFCore.Relational.Specification.Tests/Query/AdHocMiscellaneousQueryRelationalTestBase.cs
Show resolved
Hide resolved
AndriySvyryd
reviewed
Dec 8, 2023
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindMiscellaneousQuerySqlServerTest.cs
Show resolved
Hide resolved
AndriySvyryd
reviewed
Dec 8, 2023
test/EFCore.SqlServer.FunctionalTests/Query/OwnedEntityQuerySqlServerTest.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Dec 8, 2023
- Moving tests from QueryBugsTests to other more appropriate places (either AssertQuery - enabled or proper AdHoc suites) - Adding a bunch of AdHoc suites (navigations, splitting, filters, weird mappings) - Unified format of AdHoc tests Resolves #1015
roji
reviewed
Feb 11, 2024
|
|
||
| foreach (var blog in query) | ||
| { | ||
| query.ToList(); |
There was a problem hiding this comment.
@maumar this test relies on MARS capabilities, and so fails on PG. Maybe move this to AdHocNavigationsQuerySqlServerTest? The idea is not to burden 3rd-party provider maintainers with too many failing tests out-of-the-box that don't really concern them etc.
There was a problem hiding this comment.
Same thing with AdHocMiscellaneousQueryTestBase.Nested_queries_does_not_cause_concurrency_exception_sync and Select_nested_projection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1015