Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make default value '{}' for non-nullable JSON columns #32354

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Make default value '{}' for non-nullable JSON columns #32354

merged 2 commits into from
Nov 20, 2023

Conversation

roji
Copy link
Member

@roji roji commented Nov 20, 2023

Fixes #32353

@roji roji requested review from bricelam and maumar November 20, 2023 10:58
@roji roji mentioned this pull request Nov 20, 2023
Closed
@roji
Copy link
Member Author

roji commented Nov 20, 2023

Just discovered a lot of JSON column migration tests in MigrationsSqlServerTest (which would have also covered this for PG). Lifting them up to MigrationsTestBase for Sqlite, PG and other providers. /cc @maumar

@roji roji merged commit 47505c3 into dotnet:main Nov 20, 2023
7 checks passed
@roji roji deleted the JsonColumnDefault branch November 20, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

@bricelam bricelam Awaiting requested review from bricelam

@maumar maumar Awaiting requested review from maumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a new (non-nullable) JSON column populates it with an empty string (invalid JSON)
2 participants
@roji @ajcvickers