Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.x] Disable trigger enumeration on Azure Synapse Analytics, where triggers are not supported #31036

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Jun 6, 2023

See https://learn.microsoft.com/azure/synapse-analytics/sql/overview-features

Fixes #30998

Description

Azure Synapse databases do not support triggers. We started checking for triggers in EF Core 7, which causes scaffolding from a Synapse database to fail.

Customer impact

Crash attempting to scaffold from a Synapse database. Workaround is to use the EF Core Power Tools, which have already been fixed.

How found

Customer reports 7.0

Regression

Yes.

Testing

Manual testing.

Risk

Low. Not quirked, because this is a design-time change.

@ErikEJ ErikEJ changed the title Disable trigger enumeration on Azure Synapse Analytics, where triggers anr not supported Disable trigger enumeration on Azure Synapse Analytics, where triggers are not supported Jun 6, 2023
@roji
Copy link
Member

roji commented Jun 6, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memory-thrasher
Copy link
Contributor

memory-thrasher commented Jun 6, 2023

timeout coincides with known issue with azure pipeline test cases.
https://status.dev.azure.com/_event/395035822
https://status.dev.azure.com/_event/395399131

@roji roji changed the title Disable trigger enumeration on Azure Synapse Analytics, where triggers are not supported [release/7.x] Disable trigger enumeration on Azure Synapse Analytics, where triggers are not supported Jun 7, 2023
@ajcvickers
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Jul 5, 2023

@roji Will this make 7.0.9 (assume July) ??

@wtgodbe wtgodbe merged commit c8b267d into dotnet:release/7.0 Jul 6, 2023
@wtgodbe wtgodbe modified the milestones: 7.0.9, 7.0.10 Jul 6, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Jul 6, 2023

Will this make 7.0.9 (assume July) ??

This will ship in August (7.0.10)

@ajcvickers ajcvickers removed this from the 7.0.10 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants