[release/7.0] Stop skipping shadow skip navigation slots when creating the shadow values array #30911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
May 17, 2023
|
Nice, are there plans of the release date of this version? |
|
@luizfbicalho This is merged for 7.0.8, which is scheduled for July. |
So sad that it's too long, when it will be on daily build as preview? |
|
@luizfbicalho It should already be in the daily builds for 8, since it was merged for 8 on May 17. There are no daily builds for 7.0.x patch releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #30902
Fixes #30764
Description
We were previously not allocating a slot for shadow skip navigations when values come from query, since they are always null. This is fine for the common case where the navigation values are at the end of the array. However, for a shadow navigation in an abstract base class, the slot may be in the middle of the array, which then means all our indexes are off by one (or more). To fix this, we now create slots for the shadow navigations, even though they will always contain null.
Customer impact
Crash on executing queries reported by multiple customers. Perhaps more importantly, could result in silently corrupted data in other cases.
How found
Customer reports 7.0
Regression
Yes. (Even though shadow navigations are new in 7.0, we were incorrectly handling some cases in 6.0 which meant that they accidentally worked.)
Testing
Added regression tests.
Risk
Low; simple fix. Also quirked.