Fix bug where a non-sproc command comes before a sproc command #29680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
Nov 25, 2022
|
|
||
| if (columnModification.UseCurrentValueParameter) | ||
| { | ||
| parameterCount++; |
There was a problem hiding this comment.
It would also make sense to do this when building the modification command and expose the count for both types of commands though a single property
There was a problem hiding this comment.
Yeah, I thought about this, and didn't do this mainly since we want to backport the fix to 7.0, and should avoid new public APIs. I can do this in a separate PR after this is merged.
I'm not sure I'd eagerly calculate this though (during the building of the command) - it's currently only needed when output parameters are present, which is a rare sproc-only case.
AndriySvyryd
approved these changes
Nov 30, 2022
roji
added a commit
to roji/efcore
that referenced
this pull request
Dec 1, 2022
…t#29680) Fixes dotnet#29643 (cherry picked from commit 35e9e5a)
wtgodbe
pushed a commit
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29643