Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce repeating parameters #28769

Closed
wants to merge 4 commits into from
Closed

Reduce repeating parameters #28769

wants to merge 4 commits into from

Conversation

JeremyMahieu
Copy link

I have not fulfilled all pull request requirements but I need some help.
This is about issue #28768

Failing 1 test, and I don't really know why. If someone with more knowledge of the code could give direction that would be nice.

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@dnfadmin
Copy link

dnfadmin commented Aug 18, 2022

CLA assistant check
All CLA requirements met.

@JeremyMahieu
Copy link
Author

inviable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants