-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ExecuteUpdate #28626
Implement ExecuteUpdate #28626
Conversation
f5a0720
to
045de73
Compare
045de73
to
e09369f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @smitpatel.
I'm assuming you want to keep working (pushdown to PK subquery, EF.Property, EF.Default, tests...), but if you want to merge let me know and I'll approve.
I'll start a PG-side PR against this as well.
src/EFCore.Relational/Extensions/RelationalQueryableExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalQueryableExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SearchConditionConvertingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/BulkUpdates/NorthwindBulkUpdatesSqlServerTest.cs
Show resolved
Hide resolved
Will be iterating over this PR. Wanted to get it out for review because I added docs for everything (and new exception points for ExecuteUpdate). Thanks for the review on those. I will be adding more test, at least covering the same scenarios as Delete and few more for EF.Property/EF.Default/Multi-property. Wrt pushdown into subquery, it is not that straightforward for update, as the values could be using values from other tables, so if we push it down into subquery like Delete then we don't have access to those values. Trying to think of some way to rewrite to get filtering and values both. |
bcf6034
to
c5bad1f
Compare
Pending items, EF.Default & allowing joins & converting unsupported structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, forgot to submit this review.
c5bad1f
to
8d7ac14
Compare
Resolves #795
8d7ac14
to
01b7db8
Compare
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
This is a very very important feature. I have been using it since day 1. Made our life much much easier along with ExecuteDelete Thank you EFCore team |
Thanks for the positive feedback @pantonis, really good to know that this is useful for people! |
Resolves #795