Grinding the gears of war #27055
Merged
Grinding the gears of war #27055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
reviewed
Jan 3, 2022
| async, | ||
| ss => ss.Set<Gear>().Include(g => g.Weapons).Where(g => g.Nickname == "Marcus"), | ||
| elementAsserter: (e, a) => AssertInclude(e, a, expectedIncludes)); | ||
| } | ||
| elementAsserter: (e, a) => AssertInclude(e, a, new IExpectedInclude[] |
There was a problem hiding this comment.
nit: AssertInclue expected include is params so we can drop the array definition for cases with only one ExpectedInclude
|
|
maumar
approved these changes
Jan 3, 2022
#26088 for Gears query tests.
ajcvickers
force-pushed
the
GrindingTheGears1221
branch
from
c1837da
to
13e93d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26088 for Gears query tests.