Query: Avoid pushdown when joining with a subquery which can be lifted out #26476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
commented
Oct 28, 2021
test/EFCore.SqlServer.FunctionalTests/Query/ComplexNavigationsCollectionsQuerySqlServerTest.cs
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/TPTGearsOfWarQuerySqlServerTest.cs
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindSelectQuerySqlServerTest.cs
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindSelectQuerySqlServerTest.cs
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindSelectQuerySqlServerTest.cs
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindIncludeQuerySqlServerTest.cs
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/GearsOfWarQuerySqlServerTest.cs
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/CompositeKeysSplitQuerySqlServerTest.cs
Show resolved
Hide resolved
smitpatel
force-pushed
the
smit/simple
branch
from
7cf22f4 to
0086b54
Compare
smitpatel
force-pushed
the
smit/simple
branch
from
0086b54 to
6ddb4e4
Compare
…d out Part of #17622 Avoids pushdown for scenario when we cause pushdown due to order by but then we erase order by without skip take giving us simple and lift-able query again
smitpatel
force-pushed
the
smit/simple
branch
from
6ddb4e4 to
41a5edd
Compare
|
@dotnet/efteam - ping |
maumar
approved these changes
Nov 12, 2021
roji
reviewed
Nov 12, 2021
| FROM [LevelThree] AS [l1] | ||
| ) AS [t1] ON [t0].[Id] = [t1].[OneToMany_Optional_Inverse3Id] | ||
| ORDER BY [l].[Id], [t0].[Id], [t1].[Id]"); | ||
| LEFT JOIN [LevelThree] AS [l1] ON [t0].[Id] = [l1].[OneToMany_Optional_Inverse3Id] |
There was a problem hiding this comment.
❤️ very cool, thanks for doing this @smitpatel!
There was a problem hiding this comment.
I love how implementing such a change has this ripple effect on queries, opening up other simplifications in turn.
There was a problem hiding this comment.
Yeah, it's kind of like how inlining in real compilation opens the way for other optimization types... Not sure we have good examples of that in EF Core, but 🤣
ajcvickers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17622
Avoids pushdown for scenario when we cause pushdown due to order by but then we erase order by without skip take giving us simple and lift-able query again