Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding grouping tests from EF6 #26069

Merged
merged 3 commits into from
Sep 18, 2021
Merged

Adding grouping tests from EF6 #26069

merged 3 commits into from
Sep 18, 2021

Conversation

ajcvickers
Copy link
Contributor

@ajcvickers ajcvickers commented Sep 16, 2021 •
edited
Loading

As a crude measure of the gap between EF Core and EF6.

Currently:

  • 20 tests pass
  • 2 tests fail with "Translation of 'Select' which contains grouping parameter without composition is not supported."
  • 17 tests fail with general "Could not be translated."
  • 8 tests fail with different results

@ajcvickers
Copy link
Contributor Author

@smitpatel Please either file bugs for each of these, or point me to the relevant existing bug. I'll update the Skip messages with the appropriate issue numbers.

@ajcvickers
Copy link
Contributor Author

@smitpatel Updated.

@ajcvickers
Adding grouping tests from EF6
3b11cb6 
As a crude measure of the gap between EF Core and EF6.

Currently:
- 12 tests pass
- 2 tests fail with "Translation of 'Select' which contains grouping parameter without composition is not supported."
- 17 tests fail with general "Could not be translated."
- 8 tests fail with different results
@ajcvickers
Updated
8928b8e
@ajcvickers ajcvickers mentioned this pull request Sep 17, 2021
Open
@ajcvickers ajcvickers force-pushed the IfYouCantBeatThem0916 branch from d54a852 to 4dcd109 Compare September 17, 2021 19:07
@ajcvickers ajcvickers merged commit ef68226 into main Sep 18, 2021
@ajcvickers ajcvickers deleted the IfYouCantBeatThem0916 branch September 18, 2021 06:52
@ajcvickers ajcvickers mentioned this pull request Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@maumar maumar maumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajcvickers @smitpatel @maumar