[release/5.0] Don't compare values from different keys for deleted entities #24244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
changed the title
ajcvickers
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24221
Description
An exception is thrown when comparing key values of different types for deleted entities. This code was added in 5.0.0 to delete the entities in the correct order relative to inserted entities.
Customer Impact
Deleting entities with different key types always throws an exception, and this is a fairly common scenario.
A workaround would be to delete entities one by one, but this isn't possible in all scenarios.
How found
Reported by a customer.
Test coverage
Test coverage for this case has been added in this PR.
Regression?
Yes, from EF Core 3.1.
Risk
Low. This code has good test coverage aside from the above scenario. Also quirked.