-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf: unset EnableContentResponseOnWrite dotnet#22999 #23322
Perf: unset EnableContentResponseOnWrite dotnet#22999 #23322
Conversation
Generally looking good, just add ETag tests as mentioned in #22999 (comment) |
Also if the option hasn't been set to any value you can check whether we'll need the content at all: |
Thanks @AndriySvyryd I'll have do required changes. |
I've a problem with access option value |
Etag test added.
refactoring on long conditions
You can now convert this to a non-draft PR to allow the tests to run |
moved ETag tests to the ConcurencyTest class
Seems we can only have 1 constructor on DBcontext. so I couldn't add new constructor but handled with CreateOptions using default constructor of ConcurrencyContext |
src/EFCore.Cosmos/Infrastructure/CosmosDbContextOptionsBuilder.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Cosmos.Tests/Extensions/CosmosDbContextOptionsExtensionsTests.cs
Show resolved
Hide resolved
removed extra blank lines
Thanks for your contribution! |
wow. I'm so happy to contribute :) How can I track this change will release? |
It should already be available in daily builds of 6.0.0 |
I've create draft version to check implementation is correct.
See https://devblogs.microsoft.com/cosmosdb/enable-content-response-on-write/