Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable in-memory test for optional navigation access #23216

Merged
1 commit merged into from
Nov 6, 2020
Merged

Re-enable in-memory test for optional navigation access #23216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions test/EFCore.InMemory.FunctionalTests/Query/GearsOfWarQueryInMemoryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ public override Task
=> base.Null_semantics_is_correctly_applied_for_function_comparisons_that_take_arguments_from_optional_navigation_complex(
async);

[ConditionalTheory(Skip = "issue #18284")]
public override Task GroupBy_with_boolean_groupin_key_thru_navigation_access(bool async)
=> GroupBy_with_boolean_groupin_key_thru_navigation_access(async);

[ConditionalTheory(Skip = "issue #17620")]
public override Task Select_subquery_projecting_single_constant_inside_anonymous(bool async)
=> base.Select_subquery_projecting_single_constant_inside_anonymous(async);
Expand All @@ -57,10 +53,6 @@ public override Task Select_subquery_projecting_single_constant_inside_anonymous
public override Task Group_by_on_StartsWith_with_null_parameter_as_argument(bool async)
=> base.Group_by_on_StartsWith_with_null_parameter_as_argument(async);

[ConditionalTheory(Skip = "issue #18284")]
public override Task Enum_closure_typed_as_underlying_type_generates_correct_parameter_type(bool async)
=> base.Enum_closure_typed_as_underlying_type_generates_correct_parameter_type(async);

[ConditionalTheory(Skip = "issue #17386")]
public override Task Client_member_and_unsupported_string_Equals_in_the_same_query(bool async)
=> base.Client_member_and_unsupported_string_Equals_in_the_same_query(async);
Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7534,7 +7534,7 @@ public virtual Task Enum_closure_typed_as_underlying_type_generates_correct_para

return AssertQuery(
async,
ss => ss.Set<Weapon>().Where(w => prm == (int)w.AmmunitionType),
ss => ss.Set<Weapon>().Where(w => prm == (int?)w.AmmunitionType),
ss => ss.Set<Weapon>().Where(w => w.AmmunitionType != null && prm == (int)w.AmmunitionType));
}

Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.SqlServer.FunctionalTests/Query/GearsOfWarQuerySqlServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6949,7 +6949,7 @@ public override async Task Enum_closure_typed_as_underlying_type_generates_corre
await base.Enum_closure_typed_as_underlying_type_generates_correct_parameter_type(async);

AssertSql(
@"@__prm_0='1'
@"@__prm_0='1' (Nullable = true)

SELECT [w].[Id], [w].[AmmunitionType], [w].[IsAutomatic], [w].[Name], [w].[OwnerFullName], [w].[SynergyWithId]
FROM [Weapons] AS [w]
Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.SqlServer.FunctionalTests/Query/TPTGearsOfWarQuerySqlServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8073,7 +8073,7 @@ public override async Task Enum_closure_typed_as_underlying_type_generates_corre
await base.Enum_closure_typed_as_underlying_type_generates_correct_parameter_type(async);

AssertSql(
@"@__prm_0='1'
@"@__prm_0='1' (Nullable = true)

SELECT [w].[Id], [w].[AmmunitionType], [w].[IsAutomatic], [w].[Name], [w].[OwnerFullName], [w].[SynergyWithId]
FROM [Weapons] AS [w]
Expand Down