Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design: Review resources #22488

Merged
3 commits merged into from
Sep 11, 2020
Merged

Design: Review resources #22488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11cf7a1
Design: Review resources
bricelam Sep 10, 2020
9c5e325
Update src/EFCore.Design/Properties/DesignStrings.resx
bricelam Sep 11, 2020
72886b8
Update src/EFCore.Design/Properties/DesignStrings.resx
bricelam Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore.Design/Design/Internal/AppServiceProviderFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public AppServiceProviderFactory([NotNull] Assembly startupAssembly, [NotNull] I
/// </summary>
public virtual IServiceProvider Create([NotNull] string[] args)
{
_reporter.WriteVerbose(DesignStrings.FindingServiceProvider);
_reporter.WriteVerbose(DesignStrings.FindingServiceProvider(_startupAssembly.GetName().Name));

return CreateFromHosting(args)
?? CreateEmptyServiceProvider();
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Design/Design/Internal/DbContextOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public virtual void DropDatabase([CanBeNull] string contextType)
{
using var context = CreateContext(contextType);
var connection = context.Database.GetDbConnection();
_reporter.WriteInformation(DesignStrings.DroppingDatabase(connection.Database));
_reporter.WriteInformation(DesignStrings.DroppingDatabase(connection.Database, connection.DataSource));
if (context.Database.EnsureDeleted())
{
_reporter.WriteInformation(DesignStrings.DatabaseDropped(connection.Database));
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Design/Design/Internal/DesignTimeServicesBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ private void ConfigureUserServices(IServiceCollection services)
private void ConfigureReferencedServices(IServiceCollection services, string provider)
{
_reporter.WriteVerbose(DesignStrings.FindingReferencedServices(_startupAssembly.GetName().Name));
_reporter.WriteVerbose(DesignStrings.FindingReferencedServices(_assembly.GetName().Name));

var references = _startupAssembly.GetCustomAttributes<DesignTimeServicesReferenceAttribute>()
.Concat(_assembly.GetCustomAttributes<DesignTimeServicesReferenceAttribute>())
Expand Down Expand Up @@ -166,7 +167,6 @@ private void ConfigureProviderServices(string provider, IServiceCollection servi
if (providerServicesAttribute == null)
{
var message = DesignStrings.CannotFindDesignTimeProviderAssemblyAttribute(
nameof(DesignTimeProviderServicesAttribute),
provider);

if (!throwOnError)
Expand Down
54 changes: 28 additions & 26 deletions src/EFCore.Design/Properties/DesignStrings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading